Skip to content

workflows/lint: remove explicit ruby-version tag#8606

Merged
marcwrobel merged 2 commits into
masterfrom
update-setup-ruby
Oct 8, 2025
Merged

workflows/lint: remove explicit ruby-version tag#8606
marcwrobel merged 2 commits into
masterfrom
update-setup-ruby

Conversation

@chenrui333
Copy link
Copy Markdown
Member

Right now the setup-ruby does not support ruby-version-file, so we have to manually bump when updating the ruby-version file (#8600)

Signed-off-by: Rui Chen <rui@chenrui.dev>
@usta
Copy link
Copy Markdown
Member

usta commented Oct 1, 2025

@chenrui333 : @marcwrobel denies similar PR before : #6945

@chenrui333
Copy link
Copy Markdown
Member Author

chenrui333 commented Oct 1, 2025

okay, then let's remove it again.

Updated the Ruby version in the lint workflow.
@chenrui333 chenrui333 changed the title workflows/lint: update to use ruby 3.4 workflows/lint: remove explicit ruby-version Oct 1, 2025
@usta usta changed the title workflows/lint: remove explicit ruby-version workflows/lint: remove explicit ruby-version tag Oct 1, 2025
@chenrui333 chenrui333 requested a review from marcwrobel October 8, 2025 14:12
@chenrui333 chenrui333 added the ruby Pull requests that update Ruby code label Oct 8, 2025
Copy link
Copy Markdown
Member

@marcwrobel marcwrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, similar to #7347.

@marcwrobel marcwrobel merged commit 415de15 into master Oct 8, 2025
6 checks passed
@marcwrobel marcwrobel deleted the update-setup-ruby branch October 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants