Fix turret arc limit being flipped when reloading save. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculate and to clone.
- Introduce an attribute "angle of traverse" for a hardpoint. - Change a type of parameter in the constructor of class "Hardpoint." - GetAngleOfTraverse() returns some valid value in case this is Omnidirectional or a gun port. - Rewrite some comments.
…cted hardpoint and weapon. The previous commit introduced the bug.
…x some style issues.
Updating fork
Co-authored-by: tehhowch <[email protected]>
…ad of in-flight. And the turrets calculate the idle position considering the "parallel" parameter.
…3/endless-sky into oo13-limited_turret_turning_angle
Use `IsInRange` instead of comparing degrees. Co-authored-by: oo13 <[email protected]>
Construct Angle with double to avoid using private function.
Co-authored-by: Rising Leaf <[email protected]>
Co-authored-by: Rising Leaf <[email protected]>
…ess-sky into limited-turret-arc
…hips (endless-sky#8715) Co-authored-by: TomGoodIdea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: This PR addresses issue none.
Fix Details
Fix turret angle being flipped every time save is loaded, accidentally reverted the fix sometime ago. This should fix it again.
Testing Done
Compiled and test flying around fighting things with the ship from the test plugin below.
Save File
This save file can be used to verify the bugfix. The bug will occur when using {{insert commit hash / version}}, and will not occur when using this branch's build.
Test plugin (test ship available at Basic Ships shipyard.):
arclimtestplugin.zip