Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance multiprocess manager's log data #2484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

przlada
Copy link

@przlada przlada commented Oct 14, 2024

Summary

This PR proposes to extend the multiprocess manager's "Child process died" log with additional information, specifically the exit code and the name of the signal that terminated the process, similarly as gunicorn is reporting. This change will provide more context for troubleshooting issues related to unexpected process termination, particularly in scenarios such as processes being terminated due to "out of memory" errors.

The additional information will be added as extra values in the log.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for it?

Comment on lines +185 to +186
except ValueError: # pragma: no cover
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When do we have this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants