Add reason support on WebSocketDisconnectEvent
#2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
approved these changes
May 12, 2024
surick
approved these changes
May 29, 2024
frankie567
force-pushed
the
ws-disconnect-reason
branch
from
0c05370 to
4894f22
Compare
|
Now that the ASGI spec change has been merged, I think we can go forward with this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the ASGI specification repo, we recently talked about the lack of support for the
reasonfield in theWebSocketDisconnectEvent. This will be likely added to the spec soon.This PR adds support for this new addition. It doesn't need to be merged before the spec is officially modified, but we're already prepared here 😄
Checklist
I've updated the documentation accordingly.Don't think it's necessary for this change