Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy on test_websockets.py #1889

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix mypy on test_websockets.py #1889

merged 1 commit into from
Mar 6, 2023

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Mar 5, 2023

#1818 introduced this, and #1880 was merged without a rebase (I'm not sure why it was not necessary).

image

@Kludex Kludex changed the title Fix mypy on test_websockets Fix mypy on test_websockets.py Mar 5, 2023
@Kludex Kludex requested a review from adriangb March 5, 2023 20:37
@adriangb
Copy link
Member

adriangb commented Mar 5, 2023

Just need to fix the test failures 😄

@Kludex
Copy link
Member Author

Kludex commented Mar 5, 2023

it's a flaky test... 😰

@Kludex Kludex merged commit bb1b50f into master Mar 6, 2023
@Kludex Kludex deleted the fix/pipeline branch March 6, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants