Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
found
re.findall
andre.sub
usage in starlette module, we should always pre-compile regex pattern if it's possible.Althrough
re
has a built-in cache, but it has size limit and for project using many regex it still may be invalidated and pattern get unnecessary re-compile.There is still one case in
starlette/starlette/_utils.py
Line 88 in 1131b3c
It's not a simple case so I didn't touch it.
Checklist