More helpful errors in logs / terminal #7646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Improve reason_phrase for error details that are length 1 lists. Use reason_phrase property rather than non-public attribute Replace f-strings with format for py35 compatability Replace missed f-string with format
tim-mccurrach
force-pushed
the
add-more-useful-error-messages
branch
from
4e73018 to
3e1fca1
Compare
The « reason » seems beyond logging purpose as it is returned back to http client. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I don't think we'd want to do this. It's not a typical usage of HTTP reason phrases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More helpful errors in logs / terminal
Currently the default
error_handlerreturns aResponsewith error details in the response body. Django logsstatus_codeand the url. ForValidationErrors andParserErrors or any other 400 error this is just"Bad Request", which isn't particularly helpful. There are many other errors where a little extra info beyond thestatus_codeis incredibly helpful.Django's
HttpResponseBasehas areason_phraseproperty that can be used to provide more detail.detailthat is either a string, or a an array of length 1 this detail can be addedCloses #7645