Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Move setup.cfg to pyproject.toml #98

Merged
merged 17 commits into from
Jul 5, 2023
Merged

Fix: Move setup.cfg to pyproject.toml #98

merged 17 commits into from
Jul 5, 2023

Conversation

sumit-158
Copy link
Contributor

Kludex
Kludex requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the setup.cfg? 🙏

pyproject.toml Outdated Show resolved Hide resolved
sumit-158 and others added 2 commits June 20, 2023 14:45
@sumit-158
Copy link
Contributor Author

Can you remove the setup.cfg? 🙏

Oops 😁 I missed that. Thank you!

@Kludex
Copy link
Member

Kludex commented Jun 20, 2023

I don't think ruff is being used in the pipeline yet.

It still needs to remove flake8 and isort from the project (requirements.txt and somewhere in scripts), and add ruff.

@sumit-158 sumit-158 requested a review from Kludex June 20, 2023 09:18
@sumit-158
Copy link
Contributor Author

@Kludex Why does the coverage decrease?

@sumit-158
Copy link
Contributor Author

Should I decrease --fail-under=88 under 78?

Kludex
Kludex requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, you can change the coverage. I'll open an issue to increase the coverage to 100% after this is merged.

scripts/lint Outdated Show resolved Hide resolved
scripts/check Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented Jul 5, 2023 •
edited
Loading

Please rebase, and sorry the late reply.

sumit-158 and others added 5 commits July 5, 2023 18:05
Kludex
Kludex reviewed Jul 5, 2023
View reviewed changes
scripts/coverage Outdated Show resolved Hide resolved
@Kludex
Copy link
Member

Kludex commented Jul 5, 2023

Thanks @sumit-158 🙏

@Kludex Kludex merged commit 377b404 into encode:master Jul 5, 2023
@sumit-158 sumit-158 deleted the fix branch July 5, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move configuration from setup.cfg to pyproject.toml
2 participants
@sumit-158 @Kludex