Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for bh-client and bh-client-module techs #39

Merged
merged 1 commit into from
May 7, 2015
Merged

Conversation

sipayRT
Copy link
Contributor

@sipayRT sipayRT commented May 6, 2015

No description provided.

@blond blond mentioned this pull request May 6, 2015
6 tasks
@sipayRT
Copy link
Contributor Author

sipayRT commented May 6, 2015

@blond посмотри, плз. Для bh-client-module тесты добавлю после того, как внесу правки тут, чтобы в двух местах не править.


it('mimic', function () {
var test = [
'chai.should();',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему тут не используется generateTest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

потому что в этом тесте я вместо bh.apply() использую BEMHTML.apply()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А если сделать третим аргументом? )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

там уже есть третий необязательный аргумент :) Добавлять еще один аргумент ради одного теста посчитал неразумным.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ну ок )

@blond
Copy link
Member

blond commented May 6, 2015

Нету тестов на кэш.

@sipayRT
Copy link
Contributor Author

sipayRT commented May 6, 2015

Нету тестов на кэш.

@blond добавил

@sipayRT sipayRT changed the title Add tests for bh-client tech [WIP] Add tests for bh-client tech May 6, 2015
});

describe('caches', function () {
var mockBhCore = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это нужно обернуть в beforeEach.

@sipayRT sipayRT changed the title [WIP] Add tests for bh-client tech Add tests for bh-client and bh-client-module techs May 6, 2015
<script src="mocha.js"></script>
<script src="chai.js"></script>
<script src="ym.js"></script>
<script src="a.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай назовём как-то внятнее :) Например, some-ym-lib.

@blond
Copy link
Member

blond commented May 6, 2015

Тесты падают, надо исправить ;)

@blond
Copy link
Member

blond commented May 6, 2015

Не забудь добавить коментариев про запись из-за баги.

@sipayRT
Copy link
Contributor Author

sipayRT commented May 6, 2015

Тесты падают, надо исправить ;)

понятия не имею почему они падают - локально все собирается (да и ошибки какие-то странные). Добавил комментарии и перезапустил сборку

@sipayRT
Copy link
Contributor Author

sipayRT commented May 6, 2015

одну из ошибок поправил (мой косяк был), а остальные ошибки типа ENOENT, no such file or directory '/home/travis/build/enb-bem/enb-bh/test/fixtures/bh-client/index.html' какие-то странные

@sipayRT
Copy link
Contributor Author

sipayRT commented May 6, 2015

@blond всё! Если интересно в чем была проблема, то завтра расскажу :)

blond added a commit that referenced this pull request May 7, 2015
Add tests for bh-client and bh-client-module techs
@blond blond merged commit 8891fde into master May 7, 2015
@blond blond deleted the issue/31-3 branch May 7, 2015 07:02
@blond blond added the test label May 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants