-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for bh-client and bh-client-module techs #39
Conversation
@blond посмотри, плз. Для |
|
||
it('mimic', function () { | ||
var test = [ | ||
'chai.should();', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему тут не используется generateTest
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
потому что в этом тесте я вместо bh.apply()
использую BEMHTML.apply()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А если сделать третим аргументом? )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
там уже есть третий необязательный аргумент :) Добавлять еще один аргумент ради одного теста посчитал неразумным.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ну ок )
Нету тестов на кэш. |
@blond добавил |
}); | ||
|
||
describe('caches', function () { | ||
var mockBhCore = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это нужно обернуть в beforeEach
.
<script src="mocha.js"></script> | ||
<script src="chai.js"></script> | ||
<script src="ym.js"></script> | ||
<script src="a.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Давай назовём как-то внятнее :) Например, some-ym-lib
.
Тесты падают, надо исправить ;) |
Не забудь добавить коментариев про запись из-за баги. |
понятия не имею почему они падают - локально все собирается (да и ошибки какие-то странные). Добавил комментарии и перезапустил сборку |
одну из ошибок поправил (мой косяк был), а остальные ошибки типа |
@blond всё! Если интересно в чем была проблема, то завтра расскажу :) |
Add tests for bh-client and bh-client-module techs
No description provided.