Added xeus-cpp #737
Closed
Added xeus-cpp #737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Converting to draft for now ! |
5 tasks
anutosh491
commented
Mar 26, 2024
| - make # [unix] | ||
| host: | ||
| - nlohmann_json | ||
| - xeus-lite |
Collaborator
Author
There was a problem hiding this comment.
Add upper bound
- xeus-lite <2.0
anutosh491
commented
Mar 26, 2024
| - xeus-lite | ||
| - xeus >=3.0.5,<4.0 | ||
| - xtl >=0.7,<0.8 | ||
| - llvm =16.0.6 |
Collaborator
Author
There was a problem hiding this comment.
Use CppInterOp instead of llvm
Contributor
There was a problem hiding this comment.
As this is for a build of 0.3.0 then changing to CppInterOp would be unnecessary. Will be needed 0.4.0 comes out. Also CppInterOp uses llvm 17, so this change will not work if xeus-cpp 0.3.0 is not compatible with llvm 17.
Contributor
|
I think we can close this PR now as it was superseded by #937. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.