Conversation
|
CI fails on the intended error as expected. I think this is one of the few cases where landing with errors is actually the right thing... Any thoughts on the timing? As this is Friday, may we should wait until Monday to land it. |
Don't you need to update the test scripts to expect the error? As it stands the failure is unexpected and prevents further test execution... Or are you saying that somehow after landing this change future PR's wont fail? Maybe I misunderstand what you are saying?
|
|
Oh wait I see.. this is landing on master.. in that case yes please ignore failures.. we don't really need/want CI on master |
Behavior is:
See #805