Skip to content

Error on the master branch. See #805#823

Merged
kripken merged 1 commit intomasterfrom
master-error
May 24, 2021
Merged

Error on the master branch. See #805#823
kripken merged 1 commit intomasterfrom
master-error

Conversation

@kripken
Copy link
Member

@kripken kripken commented May 21, 2021

Behavior is:

$ ./emsdk install 2.0.0
****
Error: You appear to be using the `master` branch of emsdk.
We recently made the switch to using `main`
In order to continue to receive updates you will need to make the switch locally too.
For normal clones without any local branches simply running the following command should be enough:
  `git checkout main`
For more information see https://github.com/emscripten-core/emsdk/issues/805
****
$ echo $?
1

See #805

@kripken kripken requested a review from sbc100 May 21, 2021 18:59
@kripken
Copy link
Member Author

kripken commented May 21, 2021

CI fails on the intended error as expected. I think this is one of the few cases where landing with errors is actually the right thing...

Any thoughts on the timing? As this is Friday, may we should wait until Monday to land it.

@sbc100
Copy link
Collaborator

sbc100 commented May 21, 2021

CI fails on the intended error as expected. I think this is one of the few cases where landing with errors is actually the right thing...

Don't you need to update the test scripts to expect the error? As it stands the failure is unexpected and prevents further test execution... Or are you saying that somehow after landing this change future PR's wont fail? Maybe I misunderstand what you are saying?

Any thoughts on the timing? As this is Friday, may we should wait until Monday to land it.

@sbc100
Copy link
Collaborator

sbc100 commented May 21, 2021

Oh wait I see.. this is landing on master.. in that case yes please ignore failures.. we don't really need/want CI on master

@kripken kripken merged commit 7e3c046 into master May 24, 2021
@kripken kripken deleted the master-error branch May 24, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants