Remove explicit closure install step #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…already seem to install google-closure-compiler-windows at least.
Collaborator
|
I this works that is awesome! |
sbc100
approved these changes
Apr 29, 2021
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm assuming its been verified to work
sbc100
pushed a commit
that referenced
this pull request
May 5, 2021
…already seem to install google-closure-compiler-windows at least. (#803)
radekdoulik
referenced
this pull request
in dotnet/emsdk
May 20, 2021
…already seem to install google-closure-compiler-windows at least. (#803)
Collaborator
|
This doesn't seem to work on linux. |
juj
added a commit
that referenced
this pull request
Mar 4, 2022
… was a great mistake, as it caused Emscripten to silently fall back to Java version of the Closure Compiler. After this PR, Closure Compiler will work on user platforms that do not have Java installed. Also forcibly remove Java version of Closure Compiler on systems where installing the native version succeeds, in order to save on code size.
juj
added a commit
that referenced
this pull request
Apr 13, 2022
… was a great mistake, as it caused Emscripten to silently fall back to Java version of the Closure Compiler. After this PR, Closure Compiler will work on user platforms that do not have Java installed. Also forcibly remove Java version of Closure Compiler on systems where installing the native version succeeds, in order to save on code size.
juj
added a commit
that referenced
this pull request
Apr 13, 2022
* Fix native Closure Compiler to work. Reverts my earlier PR #803 which was a great mistake, as it caused Emscripten to silently fall back to Java version of the Closure Compiler. After this PR, Closure Compiler will work on user platforms that do not have Java installed. Also forcibly remove Java version of Closure Compiler on systems where installing the native version succeeds, in order to save on code size. * Add note to bug * Improve google-closure-compiler-java uninstall. * Read Closure version from Emscripten repository * Skip native google-closure-compiler install when it is not present in the emscripten branch in package.json * Print error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicit closure install step, the first install command does already seem to install google-closure-compiler-windows at least.
See #802 , #793, #636.
This would help from Linux and macOS testing to see if that works for people. CC also @curiousdannii