Conversation
sbc100
force-pushed
the
create_release
branch
2 times, most recently
from
71c14c4 to
f6c160c
Compare
dschuff
approved these changes
Apr 23, 2021
Member
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
Could this script also create tags in the emscripten repository? I guess it could create tags in the emsdk repo too, but not until after the PR lands, so maybe not that convenient.
| subprocess.check_call(['git', 'checkout', '-b', branch_name], cwd=root_dir) | ||
|
|
||
| new_version = '.'.join(str(part) for part in new_version) | ||
| new_hash = emsdk.get_emscripten_releases_tot() |
Member
There was a problem hiding this comment.
Doesn't have to be in the first commit, but we should add support for picking a particular revision as the release. Maybe this script could have 2 entry points, one that creates the CL in emscripten-releases to make the build, and another that starts from here and does the rest.
Collaborator
Author
|
Sure I think both those things could be potential followups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.