Skip to content

Remove the use of a custom temp directory#791

Merged
juj merged 1 commit intomasterfrom
remove_custom_temp_directory
Apr 23, 2021
Merged

Remove the use of a custom temp directory#791
juj merged 1 commit intomasterfrom
remove_custom_temp_directory

Conversation

@juj
Copy link
Collaborator

@juj juj commented Apr 19, 2021

Remove the use of a custom temp directory. That is a bad practice, we should reuse system temp directory instead, that is what it is there for.

… should reuse system temp directory instead, that is what it is there for.
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@juj juj merged commit bda6a0c into master Apr 23, 2021
@juj juj deleted the remove_custom_temp_directory branch April 23, 2021 07:53
sbc100 pushed a commit that referenced this pull request Apr 23, 2021
… should reuse system temp directory instead, that is what it is there for. (#791)
radekdoulik referenced this pull request in dotnet/emsdk May 20, 2021
… should reuse system temp directory instead, that is what it is there for. (#791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants