Remove bash-ism from emsdk_env.sh #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directory This is a because its not possible to determine the location of as script that is currently being sources under a POSIX shell such as dash (the default ubuntu shell). Only bash has this special BASH_SCRIPT variable.
sbc100
changed the title
Collaborator
Author
|
Landing TBR to unblock #554 |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not possible to determine the location of as script that is currently
being sources under a POSIX shell such as dash (the default ubuntu shell).
Only bash has this special BASH_SCRIPT variable.
Needed for #554