Fix set environment script name for powershell #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename write_set_env_bat to write_set_env_script.
sbc100
approved these changes
Jul 11, 2020
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Thanks!
Much appreciated.
I guess we should try to add some testing for this stuff.
Also, do you know of a way to can evaluate the result of stdout, like we do with other shells? This would avoid going via the filesytem at all (which is a little racy).
Contributor
Author
|
According to this StackOverflow, it doesn't look like "sourcing" strings works that well in Powershell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change EMSDK_SET_ENV to output correct filename for powershell.
Rename write_set_env_bat to write_set_env_script.