Conversation
Previously we were asserting and generating a stack track if a download failed. However the assert is only relevant if the download succeeds. Also: - Remove an unused function - Remove extra braces from tuple destructuring
kripken
approved these changes
Sep 12, 2019
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Looks like there is one call to download_and_unzip that does not check the return value, in update_emsdk, so this change might have an effect there. Maybe worth adding a check there and print an error if the download failed?
vargaz
pushed a commit
to vargaz/emsdk
that referenced
this pull request
Nov 22, 2023
Contributes to dotnet/source-build#3435 Adds comments to source-build files asking for the inclusion of the source-build team in PRs that alter `SourceBuild*` files. Non-reviewed changes could potentially cause issues down the line, be it in the downstream repos or the product build (as has happened in the past, see dotnet/source-build#3435 (comment))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we were asserting and generating a stack track if a
download failed. However the assert is only relevant if the download
succeeds.
Also: