Skip to content

Re-enable tests on mac after emscripten roll #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Aug 30, 2019
Merged

Re-enable tests on mac after emscripten roll #347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,6 @@ def hack_emsdk(marker, replacement):


def test_lib_building(emcc, use_asmjs_optimizer):
# TODO(sbc): Re-enable this part of the test once this upstream emscripten fix
# makes it into a release:
# https://github.com/emscripten-core/emscripten/pull/9347
if MACOS:
return

def test_build(args, expected=None, unexpected=None):
checked_call_with_output(emcc + ' hello_world.cpp' + args,
expected=expected,
Expand Down