Conversation
dschuff
reviewed
Aug 28, 2019
sbc100
force-pushed
the
circleci
branch
15 times, most recently
from
f1d5a21 to
2b6e215
Compare
sbc100
changed the title
- Add EMSDK_NOTTY variable which we can use on CI to prevent tty output. - Add test.bat for windows which mirrors test.sh. - Remove travis support
Collaborator
Author
|
This change should be good to go now! |
kripken
approved these changes
Aug 29, 2019
| check_call('./emsdk update') | ||
| run_emsdk('update') | ||
|
|
||
| print('verify downloads exist for all OSes') |
Member
There was a problem hiding this comment.
We can avoid downloading for all 3 OSes in each OS now that we have testing for them all.
But can leave for later.
Collaborator
Author
|
We need to wait for emscripten-core/emscripten#9347 to land in a release. Or I could disable that test on mac until it does. |
Member
|
I can tag a release tomorrow morning probably (assuming tree looks good). |
vargaz
pushed a commit
to vargaz/emsdk
that referenced
this pull request
Nov 22, 2023
…426.4 (emscripten-core#338) Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add circleci with support for mac, linux and windows