Upgrade node from v16.20.0 to v18.20.3 #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aheejin
approved these changes
May 22, 2024
| @@ -346,6 +346,54 @@ | |||
| "activated_env": "EMSDK_NODE=%installation_dir%/bin/node%.exe%" | |||
| }, | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
Can we delete the corresponding part with node 16 above this line then?
There was a problem hiding this comment.
We normally leave the old stuff around so that folks can still install it if they want.
kripken
approved these changes
May 22, 2024
sbc100
force-pushed
the
node_v18
branch
2 times, most recently
from
2380f9a
to
5761760
Compare
|
It looks like most of the changes in this PR are going to be more about the change to focal than to node. Maybe it's worth separating those out? |
|
I'm hoping that #1183 can land first and then this change can build on that. |
aheejin
added a commit
to aheejin/llvm-project
that referenced
this pull request
May 24, 2024
Now that we are about to upgrade emsdk's default node to v18.20.3 (emscripten-core/emsdk#1387), we can re-enable reference-types by default again. This effectively reverts llvm#90792.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 28, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 29, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
May 29, 2024
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
May 29, 2024
aheejin
added a commit
to llvm/llvm-project
that referenced
this pull request
Jun 20, 2024
Now that we are about to upgrade emsdk's default node to v18.20.3 (emscripten-core/emsdk#1387), we can re-enable reference-types by default again. This effectively reverts #90792.
AlexisPerry
pushed a commit
to llvm-project-tlp/llvm-project
that referenced
this pull request
Jul 9, 2024
Now that we are about to upgrade emsdk's default node to v18.20.3 (emscripten-core/emsdk#1387), we can re-enable reference-types by default again. This effectively reverts llvm#90792.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node v18 is that current LTS release of node and v18.20.3 is the latest release of v18.
This change means that emsdk is no longer installable on Ubuntu/Bionic 18.04, and we now require Ubuntu/Focal 20.04.
See: #1183
Fixes: #1173