Define STANDALONE_WASM at compile time as well as link time#1261
Closed
martijneken wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Define STANDALONE_WASM at compile time as well as link time#1261martijneken wants to merge 1 commit intoemscripten-core:mainfrom
martijneken wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This fixes libraries using conditional dependencies, such as Abseil: https://github.com/search?q=repo%3Aabseil%2Fabseil-cpp+standalone_wasm&type=code Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Collaborator
|
Thanks for the PR. This is correct given the current state of the world. However, after talking to some of the other maintainers, I don't think emscripten wants to commit to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes libraries using conditional dependencies, such as Abseil: https://github.com/search?q=repo%3Aabseil%2Fabseil-cpp+standalone_wasm&type=code