Add a specific flag to enable / disable the use of 'import.meta.url' #9234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the problem reported by emscripten-core#9233 and by emscripten-core#8729 while fixing the regression bug causes by emscripten-core#8940
VirtualTim
approved these changes
Aug 15, 2019
|
@VirtualTim It seems that even with your approval I can not merge the change :( |
|
Yeah I'm too untrustworthy to have write access. You'll probably need @kripken to approve this. |
|
ping @kripken |
kripken
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Thanks @adevress!
I agree with @VirtualTim that adding a flag is not wonderful, but also that this seems like the best option. Hopefully we can remove it in a few years, yeah...
|
USE_ES6_IMPORT_META should default to 0, no? |
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…mscripten-core#9234) This fixes the problem reported by emscripten-core#9233 and by emscripten-core#8729 while fixing the regression bug causes by emscripten-core#8940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem reported by #9233 and by #8729 while fixing the regression bug causes by #8940
Thank you for submitting a pull request!
If this is your first PR, make sure to add yourself to AUTHORS.