Tidy up js wrapper function generation. NFC. #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't change anything but the formatting of the output JS file WRT to wrapper functions for native exports.
jgravelle-google
approved these changes
May 14, 2019
| }; | ||
| ''' for s in receiving) | ||
| ''' % {'name': name, 'runtime_assertions': runtime_assertions}) |
There was a problem hiding this comment.
I didn't know % could take a dictionary
I prefer '{name}({args})'.format({'name': name, 'args': args}) for this sort of thing, but it's probably moot. In particular it swaps paren ambiguity for curly ambiguity, so lgtm or whatever (although .format escapes curly ambiguity with {{... anyway neither option is great so who cares)
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
This doesn't change anything but the formatting of the output JS file WRT to wrapper functions for native exports.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
This doesn't change anything but the formatting of the output JS file WRT to wrapper functions for native exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything but the formatting of the output JS
file WRT to wrapper functions for native exports.