Allow wasm object files as input, even when WASM_OBJECT_FILES=0 is set #8600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
allow_object_input
branch
from
d05e3ce
to
d92e429
Compare
jgravelle-google
approved these changes
May 13, 2019
kripken
approved these changes
May 14, 2019
|
Yes. WASM_OBJECT_FILES at compile time means "please output a wasm object file". WASM_OBJECT_FILES at link time means "use libraries in the form of wasm object files". In the long run both of these should be replaced by some kind of LTO flag. |
aardappel
approved these changes
May 14, 2019
|
While fixing this I found a bug in our LTO implementation. Fixed upstream: https://reviews.llvm.org/D61924. Will need to wait for the waterfall to get a clean build of that before this change can lang I think. |
Specifying WASM_OBJECT_FILES=0 on the link line is current needed if one want to select LTO libraries. However this should not exclude some input being wasm object files. Fixes #8599
sbc100
force-pushed
the
allow_object_input
branch
from
d92e429
to
993c990
Compare
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
emscripten-core#8600) Specifying WASM_OBJECT_FILES=0 on the link line is current needed if one want to select LTO libraries. However this should not exclude some input being wasm object files. Fixes emscripten-core#8599
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…=0 is set (emscripten-core#8600)" This reverts commit 4aa04c5.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…=0 is set (emscripten-core#8600)" This reverts commit 4aa04c5.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
emscripten-core#8600) Specifying WASM_OBJECT_FILES=0 on the link line is current needed if one want to select LTO libraries. However this should not exclude some input being wasm object files. Fixes emscripten-core#8599
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying WASM_OBJECT_FILES=0 on the link line is current needed if
one want to select LTO libraries. However this should not exclude
some input being wasm object files.
Fixes #8599