Show a clear error on -o pointing to an invalid directory. fixes #8549 #8551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
May 6, 2019
emcc.py
Outdated
| # target is just a basename, then dirname is '', which os.path.exists would | ||
| # report as not existing) | ||
| dirname = os.path.dirname(target) | ||
| if dirname and not os.path.exists(dirname): |
There was a problem hiding this comment.
You should be more specific here and use "os.path.isdir(dirname)".
| # (note that we must check that dirname is not the empty string - if the | ||
| # target is just a basename, then dirname is '', which os.path.exists would | ||
| # report as not existing) | ||
| dirname = os.path.dirname(target) |
There was a problem hiding this comment.
I don't think the final sentence in brackets is necessary. It obvious enough (I think) what if dirname and not os.path.exists(dirname): is doing.
There was a problem hiding this comment.
How about the following comment
Check for the existence of the output directory now, to avoid having to do so repeatedly when each of the various output files (.mem, .wasm, etc) is written. This gives a more useful error message than the IOError and python backtrace that users would otherwise see.
|
For reference the way native toolchains report this (both clang and gcc) is:
|
|
Thanks for the feedback @sbc100 , should be addressed now. |
sbc100
approved these changes
May 8, 2019
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…ripten-core#8549 (emscripten-core#8551) Without this, Python will give an error "no such file" when we try to write to that file, which can be confusing. Worse, this will happen on the first file we try to write to, which may be one of the helper files (.wasm, .mem, etc.), which is even more confusing.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…ripten-core#8549 (emscripten-core#8551) Without this, Python will give an error "no such file" when we try to write to that file, which can be confusing. Worse, this will happen on the first file we try to write to, which may be one of the helper files (.wasm, .mem, etc.), which is even more confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Python will give an error "no such file" when we try to write to that file, which can be confusing. Worse, this will happen on the first file we try to write to, which may be one of the helper files (.wasm, .mem, etc.), which is even more confusing.