Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup build_library test helper #8543

Merged
merged 1 commit into from
May 3, 2019
Merged

Cleanup build_library test helper #8543

merged 1 commit into from
May 3, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 3, 2019

  • Use chdir context manager
  • Remove used arguments
  • Remove "build multiple times" loop. It seems that its no longer
    needed.

This required a fix to the box2d build to remove an invalid pragma.
This file no longer exists in box2d upstream so it shouldn't be a
problem if we ever want to update.

This required a fix to the box2d build to remove an invalid pragma.
This file no longer exists in box2d upstream so it shouldn't be a
problem if we ever want to update.
@sbc100 sbc100 merged commit 9d0ace5 into incoming May 3, 2019
@sbc100 sbc100 deleted the cleanup branch May 3, 2019 23:55
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this pull request May 21, 2019
This required a fix to the box2d build to remove an invalid pragma.
This file no longer exists in box2d upstream so it shouldn't be a
problem if we ever want to update.
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
This required a fix to the box2d build to remove an invalid pragma.
This file no longer exists in box2d upstream so it shouldn't be a
problem if we ever want to update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants