-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getdents syscall to handle seekdir/telldir #8540
Conversation
Directory seeking was broken, this change makes syscall220() respect the current directory offset. Fixes emscripten-core#8526
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for taking care of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe retitle this something like "Fix getdents syscall to handle seekdir/telldir" ?
And mention that we switch to forward iteration?
Other than that his lgtm.
Gentle ping |
Can you add yourself the AUTHORS file if you are not already there? |
Already on AUTHORS! Line 381 in 07de93c
|
Directory seeking was broken, this change makes syscall220() respect the current directory offset.
Directory seeking was broken, this change makes syscall220() respect the current directory offset.
Directory seeking was broken, this change makes syscall220() respect
the current directory offset.
Fixes #8526