Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getdents syscall to handle seekdir/telldir #8540

Merged
merged 3 commits into from
May 7, 2019

Conversation

rianhunter
Copy link
Contributor

Directory seeking was broken, this change makes syscall220() respect
the current directory offset.

Fixes #8526

Directory seeking was broken, this change makes syscall220() respect
the current directory offset.

Fixes emscripten-core#8526
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for taking care of this.

system/lib/fetch/asmfs.cpp Show resolved Hide resolved
src/library_syscall.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe retitle this something like "Fix getdents syscall to handle seekdir/telldir" ?

And mention that we switch to forward iteration?

Other than that his lgtm.

@rianhunter rianhunter changed the title Fix syscall220() Fix getdents syscall to handle seekdir/telldir May 3, 2019
@rianhunter
Copy link
Contributor Author

Gentle ping

@sbc100
Copy link
Collaborator

sbc100 commented May 6, 2019

Can you add yourself the AUTHORS file if you are not already there?

@rianhunter
Copy link
Contributor Author

Already on AUTHORS!

* Rian Hunter <[email protected]>

@sbc100 sbc100 merged commit b5586dc into emscripten-core:incoming May 7, 2019
@rianhunter rianhunter deleted the fix_readdir branch May 7, 2019 00:22
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this pull request May 21, 2019
Directory seeking was broken, this change makes syscall220() respect
the current directory offset.
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
Directory seeking was broken, this change makes syscall220() respect
the current directory offset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

telldir/seekdir do not work
2 participants