-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: Add support for C source files in runner.do_run_in_out_file_test #8529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
run_in_out_test_c
branch
3 times, most recently
from
May 1, 2019 20:46
f6953b0
to
35aca3c
Compare
Honor the source file extension, which means that quite a few C++ sources had to be renamed because they were called `.c`. Also, increase usage of do_run_in_out_file_test.
sbc100
changed the title
testing: Add support for C source in runner.do_run_in_out_file_test
testing: Add support for C source files in runner.do_run_in_out_file_test
May 2, 2019
jgravelle-google
approved these changes
May 2, 2019
I've ran into this while trying to run an individual test file manually and wondering why the behavior was different, thanks for taking the time to canonicalize it |
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…test (emscripten-core#8529) Honor the source file extension, which means that quite a few C++ sources had to be renamed because they were called `.c`. Also, increase usage of do_run_in_out_file_test.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…ut_file_test (emscripten-core#8529)" This reverts commit 4099f5b.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…ut_file_test (emscripten-core#8529)" This reverts commit 4099f5b.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…test (emscripten-core#8529) Honor the source file extension, which means that quite a few C++ sources had to be renamed because they were called `.c`. Also, increase usage of do_run_in_out_file_test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honor the source file extension, which means that quite a few C++ sources had
to be renamed because they were called .c.
Also, increase usage of do_run_in_out_file_test