test_other: Add helper function to verify expected failing commands. NFC. #8518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
test_other_helper
branch
from
ff4775d
to
2df2652
Compare
kripken
approved these changes
Apr 30, 2019
| @@ -18,7 +18,7 @@ from tools import shared | |||
| if len(sys.argv) != 2 or \ | |||
| not re.match(r"^[\w\W_][\w\W_\d]*$", sys.argv[1]) or \ | |||
| not (sys.argv[1] in dir(shared)): | |||
| print('Usage: em-config VAR_NAME') | |||
| print('Usage: em-config VAR_NAME', file=sys.stderr) | |||
There was a problem hiding this comment.
change looks unrelated? seems ok though
tests/test_other.py
Outdated
| @@ -7830,15 +7807,24 @@ def test_binaryen_mem(self): | |||
| else: | |||
| self.assertEqual(parts[6], str(expect_max)) | |||
|
|
|||
| def expect_fail(self, cmd, **args): | |||
There was a problem hiding this comment.
the location here seems a bit odd - perhaps all the way up at the top?
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…mmands. NFC. (emscripten-core#8518)" This reverts commit a4eea28.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…mmands. NFC. (emscripten-core#8518)" This reverts commit a4eea28.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.