Fix WASM=0 warning in gen_struct_info #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 25, 2019
tools/shared.py
Outdated
| @@ -180,9 +180,9 @@ def check_call(cmd, *args, **kw): | |||
| try: | |||
| return run_process(cmd, *args, **kw) | |||
| except subprocess.CalledProcessError as e: | |||
| exit_with_error("'%s' failed (%d)", ' '.join(cmd), e.returncode) | |||
| exit_with_error("'%s' failed (%d)", ' '.join(e.cmd), e.returncode) | |||
There was a problem hiding this comment.
what's the difference between cmd and e.cmd?
There was a problem hiding this comment.
Nothing really in this case. e.cmd is available whenever you catch this exception. cmd just happens to be a local here too and should be identical.
kripken
approved these changes
Apr 25, 2019
Also, try to give more meaning errors when embuilder fails.
sbc100
force-pushed
the
fix_warning_in_gen_struct_info
branch
from
b1d5874
to
ddcb6a4
Compare
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
Also, try to give more meaning errors when embuilder fails.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 8d3b178.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 8d3b178.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Also, try to give more meaning errors when embuilder fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, try to give more meaning errors when embuilder fails.