Update emdump.py #8488
Merged
Update emdump.py #8488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… diffs of only changed contents.
|
I don't think anyone's read this tool in depth - blank lgtm to land changes to it. Might be nice to add a test for it, perhaps. |
|
Thanks - I am a bit wary to add testing, I don't want to impose anyone to need to keep the tool working, especially if asm.js is one the way out. Not yet sure what to do about it for wasm - have been using Bloaty a bit, but it has a codebase that is far from compatible to build on Windows. |
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
… diffs of only changed contents. (emscripten-core#8488)
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…and show diffs of only changed contents. (emscripten-core#8488)" This reverts commit 5e27ed1.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…and show diffs of only changed contents. (emscripten-core#8488)" This reverts commit 5e27ed1.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
… diffs of only changed contents. (emscripten-core#8488)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update emdump.py to be able to collapse templates under one, and show diffs of only changed contents.