WebGL2 wait sync fixes #8460
Merged
WebGL2 wait sync fixes #8460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @coopersimon! Would be good to have a bug on that chromium issue (with timeout 0) if there isn't already one, cc @kenrussell |
|
Chrome doesn't allow the main thread of the JavaScript process to block. The choice of 0 for the MAX_CLIENT_WAIT_TIMEOUT_WEBGL is deliberate. Clients can still essentially poll for completion of a sync object by passing a 0 timeout. |
|
Thanks @kenrussell, sounds like we don't need to do anything here then. |
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
Handle the i64 constant in those function signatures. Fixes emscripten-core#8458
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 44b7f4a.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 44b7f4a.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Handle the i64 constant in those function signatures. Fixes emscripten-core#8458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8458
A bit messy in the .c file, but I couldn't think of a good way of expanding the 64-bit int in a re-usable manner.
I tested this on Chrome 73 and Firefox 66, and it worked on both - however for some reason Chrome's max timeout for these functions is set to 0, so it instantly fails there.