refactor check_all_implemented. NFC #8453
Conversation
- return if we do not check for undefined_symbols - removed unused function
emscripten.py
Outdated
| if not shared.Settings.ERROR_ON_UNDEFINED_SYMBOLS and not shared.Settings.WARN_ON_UNDEFINED_SYMBOLS: | ||
| return | ||
| # only interested in those which are not in all_implemented | ||
| notinImplemented = list(set(shared.Settings.ORIGINAL_EXPORTED_FUNCTIONS) - set(all_implemented)) |
There was a problem hiding this comment.
how about missing as the name for this variable? and the comment could be "the initial list of missing functions are those we expected to export, but were not implemented in compiled code".
|
If this is a pure refactor, can you add ". NFC" to the end of the PR title? (that stands for Non-Functional Change). I know we don't always do this for emscripten but its a nice convention from llvm that I've love to see used more here. |
waterlike86
changed the title
oh this is totally skipped now in dynamic linking because of the early return. what used to take 25mins running this function used to take 15 mins, when |
Done. |
waterlike86
changed the title
|
Thanks @waterlike86! Oh, actually NFC is not relevant here I think, as this isn't a pure refactor - it's an optimization (skips running unnecessary code)? I'll remove the NFC when I merge |
make it more efficient and skip it entirely when possible
make it more efficient and skip it entirely when possible
possible fix for #8447