Move all js library decisions to a single location #8428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Apr 10, 2019
| @@ -3156,8 +3156,6 @@ def process_libraries(libs, lib_dirs, settings_changes, input_files): | |||
| if not found: | |||
| libraries += shared.Building.path_to_system_js_libraries(lib) | |||
|
|
|||
| # Certain linker flags imply some link libraries to be pulled in by default. | |||
| libraries += shared.Building.path_to_system_js_libraries_for_settings(settings_changes) | |||
There was a problem hiding this comment.
I think you can also remove the settings_changes arg from this function too.
There was a problem hiding this comment.
Hmm.. you can also just remove Found completely and return on line 3150?
There was a problem hiding this comment.
Hmm, yeah, but then we'd need to duplicate the 'SYSTEM_JS_LIBRARIES="' + ','.join(libraries) + '"' line. Not sure which I prefer.
sbc100
approved these changes
Apr 10, 2019
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…n-core#8428)" This reverts commit fb9b1dd.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…n-core#8428)" This reverts commit fb9b1dd.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was spread out in 2 places before, needlessly.