Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old TODO #8412

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Remove old TODO #8412

merged 1 commit into from
Apr 8, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Apr 8, 2019

This TODO is misleading as it was fixed in #8055.

This TODO is misleading as it was fixed in #8055.
@sbc100 sbc100 requested review from kripken and juj April 8, 2019 17:15
@sbc100 sbc100 merged commit 928c1f9 into incoming Apr 8, 2019
@sbc100 sbc100 deleted the remove_todo branch April 8, 2019 18:43
@juj
Copy link
Collaborator

juj commented Apr 12, 2019

Thanks!

VirtualTim pushed a commit to VirtualTim/emscripten that referenced this pull request May 21, 2019
This TODO is misleading as it was fixed in emscripten-core#8055.
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
This TODO is misleading as it was fixed in emscripten-core#8055.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants