-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused JS globals for stdin/stdout/stderr #8410
Conversation
Am I missing something? |
Looks like these variable go back to 16f60de, but I don't see them used today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these might be leftovers from when we did more of that in JS, yes.
(However, that one other
test failure makes me worry we are missing something?)
These globals are defined in musl C code so as far as I can tell are never used.
Looks like we have a test there is hyper sensitve to size of static data:
Will fix. |
ec5c33a
to
7c706ad
Compare
Also, makeStaticAlloc default to 16 byte alignment so this saves 48 bytes (in the debug build only I guess) |
These globals are defined in musl C code so as far as I can tell are never used.
…core#8410)" This reverts commit 178174f.
…core#8410)" This reverts commit 178174f.
These globals are defined in musl C code so as far as I can tell are never used.
These globals are defined in musl C code so as far as I can tell
are never used.