Add BINARYEN_FEATURES, and use that to pass clang feature flags to binaryen #8403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test here may not pass depending on what node version we have on the bots - if it fails I'll remove it. |
|
This now just removes the feature section code, so that we can just rely on the features section. |
|
Rewritten to be feature section friendly, and now it expects to get the list of features as |
|
Also updates binaryen to version_77, and adds a TODO test (which passes on v8 master, but not node lts yet). |
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
Gets the list of features as metadata['features'] from wasm-emscripten-finalize. It then passes those to the various invocations we do of binaryen tools. Also updates binaryen to version_77 for the binaryen side of things, and adds a TODO test (which passes on v8 master, but not node LTS yet).
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 9e2efb0.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This reverts commit 9e2efb0.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Gets the list of features as metadata['features'] from wasm-emscripten-finalize. It then passes those to the various invocations we do of binaryen tools. Also updates binaryen to version_77 for the binaryen side of things, and adds a TODO test (which passes on v8 master, but not node LTS yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using nontrapping float to int, which makes e.g. fasta 10% faster or so.