Mention that closure errors may be clearer with -g1, since then it isn't all on one line #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't all on one line
sbc100
approved these changes
Apr 2, 2019
tools/shared.py
Outdated
| @@ -2577,7 +2577,7 @@ def closure_compiler(filename, pretty=True): | |||
| proc = run_process(args, stderr=PIPE, check=False) | |||
| if proc.returncode != 0: | |||
| sys.stderr.write(proc.stderr) | |||
| exit_with_error('closure compiler failed (rc: %d)', proc.returncode) | |||
| exit_with_error('closure compiler failed (rc: %d. the error message may be clearer with -g1)', proc.returncode) | |||
There was a problem hiding this comment.
Good idea, added a check for whether the -g1 hint is needed or not.
sbc100
approved these changes
Apr 3, 2019
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…n't all on one line (emscripten-core#8389)
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…en it isn't all on one line (emscripten-core#8389)" This reverts commit 8204c0e.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…en it isn't all on one line (emscripten-core#8389)" This reverts commit 8204c0e.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…n't all on one line (emscripten-core#8389)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.