Delete unused build_project method and move build_library to test/runner.py. NFC. #8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Apr 1, 2019
…ner.py. NFC. build_library only had one non-test caller, and it turns out that was itself dead code.
sbc100
force-pushed
the
move_build_library
branch
from
783be69
to
a071510
Compare
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…ner.py. NFC. (emscripten-core#8379) build_library only had one non-test caller, and it turns out that was itself dead code.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…test/runner.py. NFC. (emscripten-core#8379)" This reverts commit 04a83ff.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…test/runner.py. NFC. (emscripten-core#8379)" This reverts commit 04a83ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_library only had one non-test caller, and it turns out that
was itself dead code.