Simplify handling of ll file generations in test code. NFC #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Apr 1, 2019
sbc100
force-pushed
the
remove_ll_to_js
branch
2 times, most recently
from
5a67663
to
01b63af
Compare
sbc100
force-pushed
the
remove_ll_to_js
branch
2 times, most recently
from
c7093c3
to
89cc818
Compare
- Remove or simplify test methods such as do_ll_run and ll_to_js - Make llvm_dis and llvm_as helpers less magical (always specify output) - Write temorary .ll files to current directory (avoids creating files in the source tree)
sbc100
changed the title
|
This PR ended up being a little more extensive that I had previously imagined. Please take another look. Its indented to be a NFC. |
sbc100
changed the title
kripken
approved these changes
May 4, 2019
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…e#8378) - Remove or simplify test methods such as do_ll_run and ll_to_js - Make llvm_dis and llvm_as helpers less magical (always specify output) - Write temorary .ll files to current directory (avoids creating files in the source tree)
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…pten-core#8378)" This reverts commit 7d65c0c.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
…pten-core#8378)" This reverts commit 7d65c0c.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
…e#8378) - Remove or simplify test methods such as do_ll_run and ll_to_js - Make llvm_dis and llvm_as helpers less magical (always specify output) - Write temorary .ll files to current directory (avoids creating files in the source tree)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files in the source tree)