Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print more compiler stages (makes -v more useful) #8350

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Print more compiler stages (makes -v more useful) #8350

merged 1 commit into from
Mar 28, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 27, 2019

Thank you for submitting a pull request!

If this is your first PR, make sure to add yourself to AUTHORS.

@sbc100 sbc100 requested a review from kripken March 27, 2019 00:41
kripken
kripken approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember when we added print_compiler_stage, but I worry it's creating another "path" to logging, alongside EMCC_DEBUG. Could that function perhaps check if -v is present (as it does now) or if DEBUG? Then DEBUG would contain a superset?

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 27, 2019

I added it pretty recently. Its for compatibility with clang and gcc which print their sub-commands out with -v. I find EMCC_DEBUG to be way too much information most of the time. I've been thinking of making it a subset yes, and also integrating into check_call so it can show all just sub-commands.

I still think this is an incremental improvement.

Check out -v and see if you like it more than full on EMCC_DEBUG as well for many use cases.

@sbc100 sbc100 merged commit 66c242a into incoming Mar 28, 2019
@sbc100 sbc100 deleted the print_compiler_stages branch March 28, 2019 02:08
VirtualTim pushed a commit to VirtualTim/emscripten that referenced this pull request May 21, 2019
@sbc100 @VirtualTim
Print more compiler stages (makes -v more useful) (emscripten-core#8350)
3c178bf
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
@VirtualTim
Revert "Print more compiler stages (makes -v more useful) (emscripten…
3308652 
…-core#8350)"

This reverts commit 3c178bf.
VirtualTim added a commit to VirtualTim/emscripten that referenced this pull request May 23, 2019
@VirtualTim
Revert "Print more compiler stages (makes -v more useful) (emscripten…
527b6f4 
…-core#8350)"

This reverts commit 3c178bf.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken