Bump EMSCRIPTEN_METADATA_MINOR#8016
Merged
juj merged 1 commit intoemscripten-core:incomingfrom Feb 6, 2019
Merged
Conversation
kripken
reviewed
Feb 6, 2019
tools/shared.py
Outdated
| # whenever metadata section changes structure | ||
| # NB: major version 0 implies no compatibility | ||
| (EMSCRIPTEN_METADATA_MAJOR, EMSCRIPTEN_METADATA_MINOR) = (0, 0) | ||
| (EMSCRIPTEN_METADATA_MAJOR, EMSCRIPTEN_METADATA_MINOR) = (0, 1) |
Member
There was a problem hiding this comment.
sorry, the right thing is EMSCRIPTEN_ABI_MINOR, a few lines down - the metadata structure did not change, the ABI did.
lgtm with that (bump 1 to 2 there)
Member
|
The metadata is not emitted by default. It must be turned on by |
juj
force-pushed
the
bump_emscripten_metadata_minor
branch
from
fe4cd9d to
607e916
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is what was requested in #7911 (comment) , but updated.
Is this Emscripten version + metadata something that is burned into all builds that Emscripten does? Have not seen this before.