-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Closure Compiler Java update #5720
Merged
kripken
merged 15 commits into
emscripten-core:incoming
from
nazar-pc:google-closure-compiler-java-update
Nov 7, 2017
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
4e1aead
Google Closure Compiler updated to latest v20171023.0.0
nazar-pc e8adafb
Some new externs added to please Closure Compiler, small tweaks to re…
nazar-pc 247a17c
Rewrite multiple `f.write()` calls into single call with more readabl…
nazar-pc 5b13367
Fix for multiple duplicated `var ptr` declarations.
nazar-pc 8b40672
More externs tweaks
nazar-pc 6e0cb98
Suppress a lot of warnings that naturally occur in asm.js code
nazar-pc d6fe775
Closure Compiler should run without errors now (warnings are present,…
nazar-pc 595dd54
Fix JS optimizer to properly work with added suppression comment (res…
nazar-pc 3572ac8
WebIDL fixes for modern Closure Compiler
nazar-pc bb8907a
Fixing last failing `asm2` tests
nazar-pc b2e9fb8
Removed externs already included in latest Closure Compiler
nazar-pc 0350265
Fix for multiple declarations of `ASSERTION` variable.
nazar-pc c27814b
Fixed typo that caused test to fail under Closure Compiler
nazar-pc a5ef87f
Suppress errors about undefined variables
nazar-pc 0a1cb86
Small tweaks as suggested in review
nazar-pc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because we start to unconditionally print
var ASSERTIONS
later down in this PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Under some circumstances
ASSERTIONS
was defined twice and Closure Compiler complained. So I've made sure it is always defined exactly once. Closure Compiler can remove it from source code later if not used at all.