Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eval and setattr instead of exec #5685

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Use eval and setattr instead of exec #5685

merged 1 commit into from
Oct 18, 2017

Conversation

jgravelle-google
Copy link
Contributor

Fixes emcc with python 2 after #5610

@dschuff
Copy link
Member

dschuff commented Oct 17, 2017

We have eval in emcc? 😭

@jgravelle-google
Copy link
Contributor Author

I mean, we do now 😀
... And also in parse_args for the --js-opts, --llvm-opts, and --llvm-lto parameters

@kripken
Copy link
Member

kripken commented Oct 17, 2017

Better eval than exec ;)

@dschuff dschuff mentioned this pull request Oct 18, 2017
Merged
@sbc100 sbc100 merged commit 63f446f into emscripten-core:incoming Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgravelle-google @dschuff @kripken @sbc100