Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defunct hasInlineJS check #5649

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Remove defunct hasInlineJS check #5649

merged 1 commit into from
Oct 12, 2017

Conversation

erikdubbelboer
Copy link
Contributor

See #5642

@kripken kripken changed the base branch from master to incoming October 11, 2017 17:43
@kripken
Copy link
Member

kripken commented Oct 11, 2017

Thanks! I redirected this to the incoming branch, where we merge new code. Please resolve the conflict there, and add yourself to AUTHORS, before we merge.

@erikdubbelboer
Copy link
Contributor Author

@kripken done. I'm not sure if waiting for the travis tests is useful. By my calculation it will start in around 24 hours. Maybe you even want to cancel the tests for this pull request seeing as they take on average 8 hours and only one tests is run at a time it seems.

@kripken
Copy link
Member

kripken commented Oct 12, 2017

Thanks! About the tests, yeah, we just added them and are still figuring it out. They are slow, but due to timezones etc. we often have a bunch of time to spare anyhow. But we might eventually pare them down or cancel them on smaller PRs etc.

@kripken kripken merged commit 559ac73 into emscripten-core:incoming Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikdubbelboer @kripken