Skip to content

Conversation

@google-yfyang
Copy link
Collaborator

This makes llvm libc on par with libcxx and libcxxabi. #26058

The remaining local changes to libc sources are very minor and is all in llvm/llvm-project#177474.

Once both of these PRs go in, we can try syncing it to the LLVM upstream HEAD.

@aheejin
Copy link
Member

aheejin commented Jan 23, 2026

Should we restore changes in string/memory_utils/inline_bcmp.h and string/memory_utils/inline_memcmp.h before #24604 too? See llvm/llvm-project#177474 (comment) for details.

@sbc100
Copy link
Collaborator

sbc100 commented Jan 23, 2026

Should we restore changes in string/memory_utils/inline_bcmp.h and string/memory_utils/inline_memcmp.h before #24604 too? See llvm/llvm-project#177474 (comment) for details.

It looks like those change are no longer needed are they? Since byte_per_byte.h is now the default? What would be the effect of restoring them?

@aheejin
Copy link
Member

aheejin commented Jan 23, 2026

Ah, you're right. Those restored are about generic/builtin.h... Nevermind.

@sbc100 sbc100 merged commit a7c5dea into emscripten-core:main Jan 23, 2026
22 of 36 checks passed
dschuff pushed a commit that referenced this pull request Jan 23, 2026
aheejin added a commit to aheejin/emscripten that referenced this pull request Jan 23, 2026
sbc100 pushed a commit that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants