Fix generated JS output to not insert indentation characters inside multiline `` strings. #26053
+106
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juj
force-pushed
the
fix_multiline_string_indentation
branch
from
b9bf767 to
be74046
Compare
sbc100
reviewed
Jan 9, 2026
test/test_other.py
Outdated
| 'closure': (['--closure', '1'],), | ||
| }) | ||
| def test_multiline_string(self, args): | ||
| self.do_run_in_out_file_test('test_multiline_string.c', cflags=['--js-library', test_file('test_multiline_string.js')] + args) |
Collaborator
There was a problem hiding this comment.
Can you add this test instead to test/test_jslib.js?
| if (text[i] == '\n') out += indent; | ||
| } | ||
| return text.replace(/\n/g, `\n${indent}`); | ||
| return out; |
Collaborator
There was a problem hiding this comment.
Hmm, I wonder at what point we should just acorn for this rather than adding complexity here? Or maybe we should just skip this process completely when the string contains any backticks at all?
Collaborator
Author
There was a problem hiding this comment.
Well, I did already go through the trouble of implementing this logic.. so simplest to land this. If it turns out to be buggy in a way that is not seen by the harness, and is difficult to fix, then we can look at alternatives.
| @@ -0,0 +1,10 @@ | |||
| #include <stdio.h> | |||
Collaborator
There was a problem hiding this comment.
Can you move this files to test/jslib?
…ultiline `` strings.
juj
force-pushed
the
fix_multiline_string_indentation
branch
from
be74046 to
8967e46
Compare
sbc100
approved these changes
Jan 15, 2026
sbc100
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. a JS library function containing
would incorrectly be emitted as
(i.e.
"abc\n def\n ghi")when the output JS was generated, changing the contents of the multiline string.