Fix browser.test_fetch_stream_abort_asan race condition #25931
Merged
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
browser.test_fetch_stream_abort_asan racecondition by avoiding double free of the fetch structure.The issue in the test was that
onprogresshandler in the test would queue a setimmediate to free the fetch structure after the turn of the event loop.But the browser might also have fed a second
onprogresshandler call before the previous setimmediate, which would also trigger a second setimmediate callback.Then the two setimmediate callbacks would fire, resulting in a double
emscripten_fetch_close()calls, and the asan test croaking:Fix the race condition by ensuring only a single abort is queued.