Remove tempfile usage from test_sanity.py. NFC #25617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here.
juj
approved these changes
Oct 22, 2025
sbc100
added a commit
that referenced
this pull request
Oct 22, 2025
Reverts #25617 The tests in question did not pass. Reverting while I figure out what happened here.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 22, 2025
This was originally landed in emscripten-core#25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
sbc100
added a commit
that referenced
this pull request
Oct 22, 2025
This was originally landed in #25617, but reverted because the tests were failing. In both cases the tempfile usage was not necessary. test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir. test_firstrun: We an just create the fake `bin` files in a subdirectory of the current directory where the test runs. No need for an external temp dir here. This change also makes 3 of the imports in this file no longer needed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both cases the tempfile usage was not necessary.
test_emconfig: In this case we can just create a new config file in the CWD. Because the test corrupts the main config file there is no risk that the test is accidentally finding the config file via CWD alone so there is no need to change directory into an external temp dir.
test_firstrun: We an just create the fake
binfiles in a subdirectory of the current directory where the test runs. No need for an external temp dir here.This change also makes 3 of the imports in this file no longer needed!