Remove references to RELOCATABLE/LINKABLE from test code. NFC
#25607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_relocatable_referecnes
branch
2 times, most recently
from
26fcac5 to
8703e97
Compare
kripken
approved these changes
Oct 21, 2025
sbc100
force-pushed
the
remove_relocatable_referecnes
branch
from
8703e97 to
4f75018
Compare
These settings are due for deprecation/removal, plus none of these tests were really depending on them specifically (as opposed to dynamic linking in general). Replace this usage with three specific simple tests that we can remove when we remove these settings. See emscripten-core#25262
sbc100
force-pushed
the
remove_relocatable_referecnes
branch
from
4f75018 to
816f4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings are due for deprecation/removal, plus none of these tests were really depending on them specifically (as opposed to dynamic linking in general).
Replace this usage with three specific simple tests that we can remove when we remove these settings.
See #25262